Fix checkDatasetFiles after merging with master #1459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merging
master
intorelease-jobs
, thedataset
schema now looks different. More specificallyorigdatablocks
field is now commented out from the schema, which led to an error in thejobs.controller
.checkDatasetFiles
validates that each file id that is passed in thejobDTO.jobParams.datasetList
corresponds to an existing file.Fixes:
To fix the error, we now store the retrieved
origdatablocks
of the requesteddataset
in a variable, instead of inside the dataset instance.